HTML5 mode fails to stop sprite playback when sound played repeatedly #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, this change reverses what fixed #1439 and causes that issue to start happening again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading Howler from 2.2.1 to 2.2.3, and using HTML5 mode on Safari 15 as a work-around for Catalina (#1513), I identified a bug where audio sprites fail to stop playback after the desired sound has played:
This is always an issue on Internet Explorer 11 with the latest howler version, since IE uses HTML5 audio.
I identified this as a regression from 0323af9 (fix for #1439). I do not know if this PR will re-introduce that bug. It definitely solves this new issue though (I'm using this fix in production and confirmed it solves the problem on Safari 15 with HTML5 mode and IE11).